You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi @chris-ramon, thanks for updating the CircleCI configuration to use more modern Go versions!
I noticed a couple of things that might need attention:
There's a mismatch between the Go version in go.mod (which specifies go 1.13) and the versions being tested in CI (1.22.0, 1.23.0, 1.24.0). Depending on your intent, you might want to update the go.mod file as well.
The coveralls job still uses circleci/golang:latest image, while the other jobs use cimg/go:. For consistency, would it make sense to update the coveralls job to use the same image prefix?
Overall, these changes look good and will help keep the CI infrastructure up to date. Let me know if you'd like me to make any additional suggestions!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
.circleci: Updates go version.Test Plan
circleciworks as expected via GitHub builds.